Fixed several bugs #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request.
I'm not sure if the master branch reflects the latest changes (local repo).
Also, the settings should probably go into the main settings dialog as
two distinct items.
- One for NumLock (allowed in all profiles)
- Volume control in another (only default profile)
Unless we allow different master volumes for different profiles.
Cheers
…On 25/01/2019, José Manuel ***@***.***> wrote:
In this pull request, the following bugs have been fixed:
* InstallTasks: call conf.save() after updating the config spec. If the user
has the option save on exit disabled, this task did nothing.
* Removed unnecesary 'u' flag on many strings (Python 3 compatibility).
* Function _getBaseValue: if an exception is raised when trying to get val1,
set val1 to None
* Function onOk: call super() in last place. If it is called in the first
line, controls are destroyed and you can't retrieve information.
* sconstruct: use the extensions keyword when calling markdown.markdown,
fixing build errors.
Let's make this add-on come to life again!
You can view, comment on, or merge this pull request online at:
#1
-- Commit Summary --
* InstallTasks: call conf.save() after updating default specification
* _getBaseValue function: put val1 in a try / except block to avoid
errors
* Removed some unicode flags (Python 3 compatibility)
* Remove more unicode flags
* OnOk function: call super function in last place, after saving config
* Sconstruct: use the extensions keyword when calling markdown.markdown
-- File Changes --
M addon/globalPlugins/sharedComputer.py (17)
M addon/installTasks.py (3)
M sconstruct (2)
-- Patch Links --
https://github.com/Robert-J-H/SharedComputer/pull/1.patch
https://github.com/Robert-J-H/SharedComputer/pull/1.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#1
|
|
Hi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, the following bugs have been fixed:
Let's make this add-on come to life again!